ci: allow the deploy workflow to be triggered manually - #53
Merged
Conversation
A run can be created with zero jobs attached to it. It then sits in `queued` indefinitely and `gh run rerun` does not recover it, because rerun replays the same run object rather than creating a new one. Only a new run object clears the state. Without `workflow_dispatch` the only way to produce one is a throwaway commit on the deploy branch. The default branch is `release`, which is where the workflow file lives, so the manual trigger is available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A workflow run can be created with zero jobs attached to it. It then sits in
queuedindefinitely, andgh run rerundoes not recover it: rerun replays the same run object instead of creating a new one. Only a new run object clears the state.Without
workflow_dispatchthe only way to produce a new run object is a throwaway commit on the deploy branch. The workflow file lives on the default branch, which is the same branch it deploys from, so the manual trigger is available.Changes
workflow_dispatchto the deploy workflow triggers.Test plan
completed success.gh workflow runagainst the deploy branch queues a run that gets jobs assigned.